Implement support for Tomcat 10 #78
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if it would be easier to land this to have it next to tomcat-9.0 support? Fedora doesn't even have tomcat10 yet, as you can see from the failing rpm builds. |
|
Possibly, though Tomcat 10 support needs modifications to the public API of the common core library, so I'm not entirely sure if it's doable without a major version bump either way. I'd like to hear from the devs on that. |
|
I added a way to switch between Tomcat 9 and Tomcat 10 support via two Maven build properties. This necessitated moving Http11NioProtocol to the tomcat-x.0 subprojects, but I think that's an alright tradeoff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for Tomcat 10, updating some method overrides and removing obsoleted functionality. Most of the changes have been made rather naively, and will probably need some tweaking and/or change requests before they can be merged.
The proposed changes compile fine on a Debian 12 machine with the current stable packages; however, these may not match versions in other distributions.
CC @tjaalton. Closes #68.